Fix #7625: Road infrastructure cost is correctly updated when upgrading your own roads. #7628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the road infrastructure cost issues, while still allowing the player to not have to pay maintenance on roads that are part of towns or scenarios (presumably this was the intent).
Also changes
CanConvertRoadType
's name toCanConvertUnownedRoadType
to make more sense for what it does. The odd name choice is probably how the bug originated in the first place.(ignore the previous commit visible in the issue which previously fixed this, which I can't get rid of because I deleted the branch - thanks GitHub)