Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-pam: set sconfigdir to /etc for usage at runtime #76718

Merged
merged 1 commit into from Jan 7, 2020
Merged

linux-pam: set sconfigdir to /etc for usage at runtime #76718

merged 1 commit into from Jan 7, 2020

Conversation

matthewbauer
Copy link
Member

So users don’t need to override the $out/etc/security files, we need
to manually set this to /etc. Override it in the install phase so that
we still get the example $out/etc/security files .

Fixes #76713

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
linux-pam: set sconfigdir to /etc for usage at runtime
f746d8e 
So users don’t need to override the $out/etc/security files, we need
to manually set this to /etc. Override it in the install phase so that
we still get the example $out/etc/security files .

Fixes NixOS#76713
@matthewbauer matthewbauer mentioned this pull request Dec 30, 2019
Closed
@FRidh FRidh added this to WIP in Staging via automation Dec 31, 2019
@matthewbauer matthewbauer changed the base branch from master to staging January 7, 2020 05:22
@matthewbauer matthewbauer merged commit 7743eba into NixOS:staging Jan 7, 2020
Staging automation moved this from WIP to Done Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matthewbauer