Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom, atom-beta: 1.36.1 -> 1.42.0, 1.37.0-beta0 -> 1.43.0-beta0 #76716

Merged
merged 1 commit into from Jan 1, 2020
Merged

atom, atom-beta: 1.36.1 -> 1.42.0, 1.37.0-beta0 -> 1.43.0-beta0 #76716

merged 1 commit into from Jan 1, 2020

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Dec 30, 2019 •
edited by veprbl

Motivation for this change

Closes: #75183

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker @NeQuissimus @ysndr

@veprbl
Copy link
Member

veprbl commented Dec 30, 2019

@GrahamcOfBorg build atom atom-beta

@NeQuissimus
Copy link
Member

I cannot run either of these:

/nix/store/rmpm5cq44v4fjj6kwgnczcaksy8gqh65-atom-1.42.0/share/atom/atom: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory

@ysndr
atom, atom-beta: 1.36.1 -> 1.42.0, 1.37.0-beta0 -> 1.43.0-beta0
9922a54 
Add shared libraries libuuid and libatk-bridge
@ysndr
Copy link
Member Author

ysndr commented Dec 31, 2019

My bad, I did not specifically run this in a pure shell so this and another shared lib were already present.
Should be fixed now though

@ysndr
Copy link
Member Author

ysndr commented Dec 31, 2019

@GrahamcOfBorg build atom atom-beta

@NeQuissimus NeQuissimus merged commit 8d39a23 into NixOS:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atom package version upgrade
3 participants
@ysndr @veprbl @NeQuissimus