Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file: 5.37 -> 5.38 #76159

Merged
merged 1 commit into from Dec 31, 2019
Merged

file: 5.37 -> 5.38 #76159

merged 1 commit into from Dec 31, 2019

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 22, 2019

Motivation for this change

https://mailman.astron.com/pipermail/file/2019-December/000246.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh added this to Needs review in Staging Dec 30, 2019
@FRidh FRidh merged commit 25fb1a0 into NixOS:staging Dec 31, 2019
Staging automation moved this from Needs review to Done Dec 31, 2019
@zowoq zowoq deleted the file branch December 31, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @FRidh