Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebsockets: propagate openssl and libuv #76717

Closed
wants to merge 1 commit into from

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Dec 30, 2019

Motivation for this change

Resolves #76714.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

jonringer commented Dec 30, 2019

according to the libwebsockets.pc, this is intended behavior:

prefix="/nix/store/0xdhyq4hj6ypa0lrsqnasz5cnjcjxr61-libwebsockets-3.2.0"
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libwebsockets
Description: Websockets server and client library
Version: 3.2.0

Libs: -L${libdir} -lwebsockets
Cflags: -I${includedir}

if openssl and libuv were meant to be propagated, you would see another line like:

Libs.private: -luv -ldl -lssl -lcrypto

@jonringer
Copy link
Contributor

However, this doesn't mean that the package has an incorrect .pc, which it likely does.

Personally, I'm against propagating libraries because it adds the dev closure (and transitively the dev closure of all dependencies) to package's runtime closure, see #71553 for an example bloat

@furrycatherder
Copy link
Contributor Author

But practical use of libwebsockets requires these dependencies, no?

The added closure size seems marginal to me:

nix path-info -Sh ./result # after                           
/nix/store/10wc552m2xacsaqfab5vac65ihp8gjsz-libwebsockets-3.2.0	 188.5M

nix path-info -Sh ./result # before
/nix/store/0xdhyq4hj6ypa0lrsqnasz5cnjcjxr61-libwebsockets-3.2.0	 186.4M

If this is an issue we should take upstream, this could just be a stopgap... 🤷‍♂️

@stale
Copy link

stale bot commented Jul 1, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 1, 2020
@jonringer
Copy link
Contributor

Seeing as this has been inactive for 6 months, and it's likely not intended behavior from upstream, im going to close

@jonringer jonringer closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libwebsockets: libuv, openssl should be propagated?
2 participants