nixos/transmission: fix from where service loads config #76701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please document the "why" part of this change also in the commit message, not only the PR message. And prefix the commit subject with "nixos/transmission: [...]". |
Currently if you specify home to be someplace else than ~/ for user then Transmissions always attempts to load the config from the default location which is $HOME/.config/transmission-daemon based on documentation: https://github.com/transmission/transmission/wiki/Configuration-Files Which means that the changes done to the config under settingsDir in ExecPreStart have no effect because they are modifying a file that is never loaded. I've added an explicit --config-dir ${settingsDir} to make sure that Transmission loads the correct config file even when home is changed. Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
Updated commit. |
bjornfor
approved these changes
Dec 30, 2019
bjornfor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently if you specify
hometo be someplace else than~/foruserthen Transmissions always attempts to load the config from the default location which is$HOME/.config/transmission-daemonbased on documentation:https://github.com/transmission/transmission/wiki/Configuration-Files
Which means that the changes done to the config under
settingsDirinExecPreStarthave no effect because they are modifying a file that is never loaded.Changes
I've added an explicit
--config-dir ${settingsDir}to make sure that Transmission loads the correct config file even whenhomeis changed.Notify maintainers
cc @edolstra @bjornfor @thoughtpolice @coreyoconnor