[Security] WPT for COOP and iframe relationships #20942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 30, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1984306
branch
from
83f2fe3
to
17f4553
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1984306
branch
3 times, most recently
from
7ad4b74
to
4638d77
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1984306
branch
4 times, most recently
from
554cc89
to
dac2dc7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1984306
branch
2 times, most recently
from
bf8788b
to
81af4fe
Compare
This adds several popup initiated from iframe tests, including the
specific test asserting that, when:
- given top-level document A;
- given Iframe B;
- A is cross-origin with B;
- A has a Cross-origin-opener-policy of "same-origin";
- B opens a popup C;
C must have the noopener property.
Bug: 922191
Change-Id: I90e2bea3ebc4f2e59653c9fc54b2858246d59c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984306
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731905}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1984306
branch
from
81af4fe
to
6248116
Compare
|
@zcorpan, not sure what to do about the status of this PR? the failure does not seem directly related to the changes introduced here, am I missing something? (Also good opportunity to FYI on this) |
|
(We have a sheriff rotation that notices blocked PRs and investigates. Takes a few hours after the test lands Chromium-side for it to show up on our dashboard.) An affected test flaked on Firefox stability checks: I would agree that this PR didn't affect that test directly, and looks like it was already flaky. Admin-merging. |
|
@ParisMeuleman thanks for the heads up. I believe that is this issue #21107 Edit: also thanks @stephenmcgruer for investigating and merging :) |
|
@annevk might be interested in this PR also |
Yep, I did not mention him here since he had a look on the chromium repo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several popup initiated from iframe tests, including the
specific test asserting that, when:
- given top-level document A;
- given Iframe B;
- A is cross-origin with B;
- A has a Cross-origin-opener-policy of "same-origin";
- B opens a popup C;
C must have the noopener property.
Bug: 922191
Change-Id: I90e2bea3ebc4f2e59653c9fc54b2858246d59c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984306
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731905}