New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify error message of 'assigning to top-level attribute' #76702
Conversation
@raboof did you get this error when you tried to add some I think this is most common case. And perhaps we can solve it the other way round - support
@nbp @infinisil what do you think? |
@danbst I ran into this when I added |
@danbst Seems to be backwards compatible, I wouldn't be against that. |
Cool, now all that's left is to squash the commits into one, with a commit message prefix like "lib/modules: ..." |
a05b9a8
to
8a9d5fc
Compare
If I understand correctly, the problem isn't so much that you're assigning to that top-level attribute, but that the assignment to the attribute (or any child of the attribute) introduces the 'config' object and prevents 'lifting' all settings to a generated 'config' object.
8a9d5fc
to
43ef3a8
Compare
Done, thanks! |
If I understand correctly, the problem isn't so much that you're assigning to
that top-level attribute, but that the assignment to the attribute (or any
child of the attribute) introduces the 'config' object and prevents 'lifting'
all settings to a generated 'config' object.
Motivation for this change
I think this would improve the new-user experience, where you're not yet so
sure where configuration options should go.