Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages: toggl-cli fix pendulum version bounds #76700

Merged
merged 1 commit into from Dec 30, 2019
Merged

python3Packages: toggl-cli fix pendulum version bounds #76700

merged 1 commit into from Dec 30, 2019

Conversation

pschuprikov
Copy link
Contributor

Motivation for this change

toggl-cli fails to build with pendulum-2.0.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pschuprikov
python3Packages.toggl-cli: relax pendulum bounds
ced3381 
    * toggl-cli fails to compile with pendulum 2.0.5
    * toggl-cli needs `pkg_resources` from `setuptools`
@ofborg ofborg bot requested a review from mmahut December 30, 2019 15:21
@mmahut
Copy link
Member

mmahut commented Dec 30, 2019

@GrahamcOfBorg build python3Packages.toggl-cli

@mmahut mmahut merged commit de4b7d5 into NixOS:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pschuprikov @mmahut