Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: use gcc7, remove build notification #76728

Merged
merged 1 commit into from Dec 31, 2019
Merged

palemoon: use gcc7, remove build notification #76728

merged 1 commit into from Dec 31, 2019

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

My original update PR was obsoleted by an automatic one, just applying some of the changes that are still open from it.

Things done

Build is too large for me to test locally right now, but the changes were tested in the previous PR.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@OPNA2608 OPNA2608 mentioned this pull request Dec 31, 2019
Closed
10 tasks
@ofborg ofborg bot requested a review from AndersonTorres December 31, 2019 04:04
@AndersonTorres
Copy link
Member

Looks good to me. But, is there some problem by compiling it with GCC 9?

AndersonTorres
AndersonTorres reviewed Dec 31, 2019
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC 7 compilation is OK. I just wanna test it with GCC9 before a definitive merge.

@OPNA2608
Copy link
Contributor Author

Looks good to me. But, is there some problem by compiling it with GCC 9?

Their instructions for compiling the codebase state:

For Linux, you will need to use GCC (clang is not currently supported as a stable compiler), 7.* strongly recommended but other versions might work too
GCC 9 has breaking changes which may not allow you to successfully build

It may be possible to compile it with GCC9, but it doesn't look like it's particularly endorsed by upstream. Since we have to stick to a known-good build setup to use the official branding, I think we should stick with GCC7.

@AndersonTorres
Copy link
Member

OK, then. I will merge it now.

P.S.: it compiles fine with gcc9.

@AndersonTorres AndersonTorres merged commit ba9fdec into NixOS:master Dec 31, 2019
@OPNA2608 OPNA2608 deleted the palemoon-improvements branch September 27, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OPNA2608 @AndersonTorres