New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hasura: init at 1.2.1 #75527
hasura: init at 1.2.1 #75527
Conversation
6311b28
to
9f4015d
Compare
9b0813a
to
6533798
Compare
4f5256f
to
18a07de
Compare
Everything works as expected now. To test it locally:
|
18a07de
to
30ab542
Compare
Updated to version |
Can confirm version |
After rebasing onto master (0e6ceb8 as of writing) the build for graphql-engine fails:
I was able to build and run (on your branch) before rebasing successfully. |
I would like to use this, is there anything I can do to help getting this PR merged? |
@GrahamcOfBorg build hasura-cli |
@offlinehacker could you rebase? |
Ok, this was quite a challenge, but was able to update to I can confirm that executables run, but i did not do any additional testing yet. So if someone has time it would be nice to check if everything works as expected. |
@GrahamcOfBorg build hasura-graphql-engine hasura-cli |
Thanks for the updated PR, @offlinehacker. I've just tested the graphql-engine and the hasura console with a development project, everything works as expected. |
I didn't have time to dig in, but those package should be coming from |
@domenkozar the problem is hasura is quite picky about some package versions(or it does not build) and haskellPackages only have one version, so for all version constrained dependencies that require older versions, I cannot use one from haskellPackages. This also seems one of limitation of haskellPackages, as it asumes only one version of package. Regardless of that I still managed to build hasura, but is not completely automated process, as alternative would probably generate a large file with dependencies, and that's not desirable in nixpkgs, which are already polluted with large auto generated files. Also three packages used by hasura are not on hackage. |
I will rebase and rebuild tomorrow, if everything still works let's merge. |
Updated to |
@GrahamcOfBorg build hasura-graphql-engine hasura-cli |
@offlinehacker Several things need to be changed:
This extension binary requires ldd ~/.hasura/plugins/bin/hasura-cli_ext
linux-vdso.so.1 (0x00007ffd2cbeb000)
libdl.so.2 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libdl.so.2 (0x00007f42c6e18000)
librt.so.1 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/librt.so.1 (0x00007f42c6e0e000)
libstdc++.so.6 => not found
libm.so.6 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libm.so.6 (0x00007f42c6cce000)
libgcc_s.so.1 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libgcc_s.so.1 (0x00007f42c6cb4000)
libpthread.so.0 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libpthread.so.0 (0x00007f42c6c93000)
libc.so.6 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libc.so.6 (0x00007f42c6ad2000)
/lib64/ld-linux-x86-64.so.2 => /nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib64/ld-linux-x86-64.so.2 (0x00007f42c6e1f000) The CLI still works with SQL migrations, but metadata doesn't. New commands such as action generator don't work too
|
The packages have been removed from |
That went exactly as I expected :) |
@domenkozar well it was best effort to package hasura, with what we have in nixpkgs. I was ready for other suggestions, but Haskell packaging facility in nixpkgs does not seem to be ready to package more complex packages. In fact according to my observations also other Haskell packages in nixpkgs break many times. |
My comment wasn't mean to criticize your work, quite on the contrary I think it's a shame that it didn't turn out differently. I propose to package with haskell.nix and cachix, just as I did with https://github.com/cachix/ghcide-nix |
About
This package is based on https://github.com/input-output-hk/cardano-explorer/tree/master/nix/nixos/graphql-engine who should also get most of the credit
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @ivan @domenkozar