Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc: 0.11.0 -> 0.12.0 #75479

Merged
merged 1 commit into from Dec 13, 2019
Merged

bcc: 0.11.0 -> 0.12.0 #75479

merged 1 commit into from Dec 13, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 11, 2019

  • fix bash shebangs
  • fix reference to $out/share/bcc/tools/lib when scripts are started from $out/bin
  • use submodules to download libbpf
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

- fix bash shebangs
- fix reference to $out/share/bcc/tools/lib when scripts are started from $out/bin
- use submodules to download libbpf
@Mic92
Copy link
Member Author

Mic92 commented Dec 12, 2019

Hold on. After reboot, bcc broke!

@Mic92 Mic92 changed the title bcc: 0.11.0 -> 0.12.0 [WIP] bcc: 0.11.0 -> 0.12.0 Dec 12, 2019
@Mic92 Mic92 changed the title [WIP] bcc: 0.11.0 -> 0.12.0 bcc: 0.11.0 -> 0.12.0 Dec 12, 2019
@Mic92
Copy link
Member Author

Mic92 commented Dec 12, 2019

It was not a reboot, but I just needed another reboot after a kernel upgrade. BCC works as advertised.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build linuxPackages.bpftrace

@Mic92 Mic92 merged commit 8d2139d into NixOS:master Dec 13, 2019
@Mic92 Mic92 deleted the bcc branch December 13, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants