Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bedtools: 2.29.0 -> 2.29.1 #75416

Merged
merged 2 commits into from Dec 10, 2019
Merged

bedtools: 2.29.0 -> 2.29.1 #75416

merged 2 commits into from Dec 10, 2019

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Dec 10, 2019

Motivation for this change

New bedtools release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

markuskowa commented Dec 10, 2019 •
edited

@GrahamcOfBorg build bedtools

@markuskowa
Copy link
Member

The build fails on darwin (can't find gcc).

@jbedo
Copy link
Contributor Author

jbedo commented Dec 10, 2019

This was the case prior to the version bump. Should be fixed in a separate pull request though?

@markuskowa
Copy link
Member

A separate commit is sufficient.

@markuskowa
Copy link
Member

Thanks for fixing it.

@markuskowa markuskowa merged commit 3922a30 into NixOS:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbedo @markuskowa