New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/gnome: update wrapper args example, remove proliferated uses #75465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now breaks down as mentioned in NixOS#75443
ofborg
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: python
8.has: documentation
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
Dec 10, 2019
10 tasks
jtojnar
reviewed
Dec 11, 2019
jtojnar
reviewed
Dec 11, 2019
jtojnar
requested changes
Dec 11, 2019
Thanks for suggestions, will commit. |
worldofpeace
force-pushed
the
gnome-args
branch
from
December 11, 2019 10:26
4936bb7
to
1a335e5
Compare
jtojnar
reviewed
Dec 11, 2019
jtojnar
reviewed
Dec 11, 2019
jtojnar
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
worldofpeace
force-pushed
the
gnome-args
branch
from
December 15, 2019 05:11
1a335e5
to
abe3475
Compare
@worldofpeace thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: python
8.has: documentation
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#75443
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @