Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.CF: fix retry condition #75528

Closed
wants to merge 1 commit into from
Closed

darwin.CF: fix retry condition #75528

wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 11, 2019

Motivation for this change

Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca861
never gets triggered.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
darwin.CF: fix retry condition
e8feb1a 
Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca861
never gets triggered.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 11, 2019
@LnL7 LnL7 mentioned this pull request Dec 11, 2019
Closed
vcunat pushed a commit that referenced this pull request Dec 12, 2019
@LnL7 @vcunat
darwin.CF: fix retry condition (close PR #75528)
d5d8b35 
Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca861
never gets triggered.
@vcunat
Copy link
Member

vcunat commented Dec 12, 2019

OK, why not try it. Pushed to staging-next, as that's where it blocked Hydra.

@vcunat vcunat closed this Dec 12, 2019
vcunat pushed a commit that referenced this pull request Jan 12, 2020
@LnL7 @vcunat
darwin.CF: fix retry condition (close PR #75528)
101fa79 
Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca861
never gets triggered.

(cherry picked from commit d5d8b35)
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@LnL7 @rvem
darwin.CF: fix retry condition (close PR NixOS#75528)
106893e 
Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca861
never gets triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @vcunat