Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conmon: v2.0.4 -> v2.0.6 #75483

Merged
merged 1 commit into from Dec 12, 2019
Merged

conmon: v2.0.4 -> v2.0.6 #75483

merged 1 commit into from Dec 12, 2019

Conversation

saschagrunert
Copy link
Member

Motivation for this change

Update conmon to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build conmon

@ofborg ofborg bot requested a review from vdemeester December 11, 2019 07:55
vdemeester
vdemeester approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@saschagrunert
conmon: v2.0.4 -> v2.0.6
9165b15 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title conmon: v2.0.4 -> v2.0.5 conmon: v2.0.4 -> v2.0.6 Dec 12, 2019
@ofborg ofborg bot requested a review from vdemeester December 12, 2019 08:43
@marsam marsam merged commit 10fbebc into NixOS:master Dec 12, 2019
@marsam
Copy link
Contributor

marsam commented Dec 12, 2019

Thanks!

@saschagrunert saschagrunert deleted the conmon branch December 13, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @marsam @vdemeester