Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-machine-xhyve: enable and fix lib9p file sharing #75432

Merged
merged 4 commits into from Jan 15, 2020
Merged

docker-machine-xhyve: enable and fix lib9p file sharing #75432

merged 4 commits into from Jan 15, 2020

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Dec 10, 2019

Motivation for this change

I wanted to run a docker-machine VM based on the xyhve hypervisor (which uses the built-in hypervisor in macOS). However, the currently packaged version did not support file system sharing, so I enabled lib9p. I then figured out that it is currently broken and my upstream pull request is pending.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @periklis

@mroi
docker-machine-xhyve: update repository location
5c01936 
The zchee repository now redirects to machine-drivers.
@mroi mroi changed the title Patch xhyve docker-machine-xhyve: enable and fix lib9p file sharing Dec 10, 2019
@ofborg ofborg bot requested review from periklis and ehmry December 10, 2019 14:43
@mroi
docker-machine-xhyve: 0.3.3 -> 0.4.0
475bf6d 
remove explicit dependencies, upstream vendorizes them properly
@mroi
docker-machine-xhyve: support lib9p shared file system
08ecf22 
The lib9p library for host-guest file sharing in xhyve needs to be built separately.
@mroi
docker-machine-xhyve: fix file mode inconsistencies
338386b 
File modes are not properly translated from L9P to host values.
Instead, they are assumed to be identical, which is wrong on macOS.
machine-drivers/docker-machine-driver-xhyve#225
@mroi mroi requested a review from marsam January 14, 2020 20:17
@marsam marsam merged commit 1f1c098 into NixOS:master Jan 15, 2020
@marsam
Copy link
Contributor

marsam commented Jan 15, 2020

Thank you @mroi

@mroi mroi deleted the patch-xhyve branch January 15, 2020 09:49
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis Awaiting requested review from periklis

@ehmry ehmry Awaiting requested review from ehmry

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroi @marsam