New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-adfs: 1.19.1 -> 1.20.0; fix build #75536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit should be:
pythonPackages.aws-adfs: 1.19.1 -> 1.20.0; fix build
otherwise LGTM
@GrahamcOfBorg build pythonPackages.aws-adfs |
@jonringer I fixed the commit message. I think the failing builds for Python 2.7 can be ignored as it will be EOL at the end of the year anyway - they relate to dependency versions not matching. |
I would either disable python2, or freeze lxml to <4.4.0 for python2, disabling for python2 would be easier
|
@jonringer I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python38 failure likely an upstream issue
https://github.com/NixOS/nixpkgs/pull/75536
1 package failed to build:
python38Packages.aws-adfs
1 package were built:
aws-adfs
@GrahamcOfBorg build aws-adfs |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @bhipple