Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeApplications: kcalcore dependencies fix #75533

Merged
merged 2 commits into from Dec 15, 2019
Merged

kdeApplications: kcalcore dependencies fix #75533

merged 2 commits into from Dec 15, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Dec 11, 2019 •
edited

Motivation for this change

kcalcore seems to be abandoned in favor of kcalendarcore

I still have errors compiling kitinerary but could not identify whout would cause that. As a consequence kdepim-addons is not building either.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre nyanloutre mentioned this pull request Dec 11, 2019
Merged
10 tasks
@nyanloutre
Copy link
Member Author

@GrahamcOfBorg build kdeApplications.kitinerary

@worldofpeace
Copy link
Contributor

@nyanloutre we updated poppler and it broke it, see KDE/kitinerary@5e001bf.
That patch doesn't apply though, but the conflict is just an include.
But even after this it doesn't build because other fixes need to be applied related to poppler.

Perhaps we can just override src to the latest released version.

@nyanloutre
Copy link
Member Author

We can also update the KDE apps directly to 19.12: https://kde.org/announcements/releases/19.12/

@worldofpeace
Copy link
Contributor

We can also update the KDE apps directly to 19.12: https://kde.org/announcements/releases/19.12/

Sounds good, this fix isn't blocking staging next is it though?

@nyanloutre
Copy link
Member Author

I don't think this fix should block staging next as the only packages failing to build are kitinerary and kdepim-addons which are not used in any other packages

@worldofpeace
Copy link
Contributor

I don't think this fix should block staging next as the only packages failing to build are kitinerary and kdepim-addons which are not used in any other packages

Ah ok. I thought there were failures in staging-next that broke the plasma5 test in deps chain.

@FRidh FRidh merged commit 2abd0a5 into NixOS:staging-next Dec 15, 2019
@nyanloutre nyanloutre deleted the akonadi_search_fix branch December 15, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@the-kenny the-kenny Awaiting requested review from the-kenny

@bkchr bkchr Awaiting requested review from bkchr

@vandenoever vandenoever Awaiting requested review from vandenoever

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @worldofpeace @FRidh