Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase,keybase-gui: 5.0.0 -> 5.1.1 #75531

Merged
merged 3 commits into from Feb 10, 2020
Merged

keybase,keybase-gui: 5.0.0 -> 5.1.1 #75531

merged 3 commits into from Feb 10, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 11, 2019 •
edited

Motivation for this change

https://github.com/keybase/client/releases/tag/v5.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[3 built, 2 copied (4.2 MiB), 1.2 MiB DL]
3 package were built:
kbfs keybase keybase-gui
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @carlsverre @np @rvolosatovs @puffnfresh

This change is Reviewable

@ofborg ofborg bot requested review from ehmry, np and puffnfresh December 11, 2019 22:14
rvolosatovs
rvolosatovs approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keybase and keybase-gui both seem to work fine on NixOS

@rvolosatovs
Copy link
Member

@GrahamcOfBorg build keybase keybase-gui

@charles-dyfis-net
Copy link
Contributor

Note that 5.1.0 was followed up with 5.1.1; this should probably be updated.

@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Dec 12, 2019 •
edited

@charles-dyfis-net Just noticed that, thanks! Will do Done.

@Br1ght0ne Br1ght0ne changed the title keybase,keybase-gui: 5.0.0 -> 5.1.0 keybase,keybase-gui: 5.0.0 -> 5.1.1 Dec 12, 2019
@judaew judaew mentioned this pull request Dec 17, 2019
Closed
10 tasks
judaew
judaew approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@judaew judaew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charles-dyfis-net Sorry for the late answer. Just now I saw your message. It's LGTM, thanks 🌟

@FRidh FRidh merged commit 0ea4e99 into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-dyfis-net charles-dyfis-net charles-dyfis-net approved these changes

@puffnfresh puffnfresh puffnfresh approved these changes

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@judaew judaew judaew approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Br1ght0ne @rvolosatovs @charles-dyfis-net @puffnfresh @judaew @FRidh