Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xandikos: init at 0.1.0 #75532

Merged
merged 1 commit into from Dec 21, 2019
Merged

xandikos: init at 0.1.0 #75532

merged 1 commit into from Dec 21, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 11, 2019

Motivation for this change

Add xandikos package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer taking over xandikos from #31096

@offlinehacker
Copy link
Contributor

Everything else looks good to me

matthiasbeyer
matthiasbeyer approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

Ma27
Ma27 approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally 👍

@Ma27 Ma27 merged commit 68dfdc2 into NixOS:master Dec 21, 2019
@matthiasbeyer
Copy link
Contributor

Nice

@0x4A6F 0x4A6F deleted the master-xandikos branch December 22, 2019 16:26
@0x4A6F 0x4A6F restored the master-xandikos branch December 22, 2019 16:28
@0x4A6F 0x4A6F mentioned this pull request Dec 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @offlinehacker @matthiasbeyer @Ma27