Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php74: Enable zip support #75444

Merged
merged 1 commit into from Dec 11, 2019
Merged

php74: Enable zip support #75444

merged 1 commit into from Dec 11, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 10, 2019

Motivation for this change

This fixes #75427

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu etu mentioned this pull request Dec 10, 2019
Closed
@ofborg ofborg bot requested a review from globin December 10, 2019 17:11
@etu
Copy link
Contributor Author

etu commented Dec 11, 2019

cc @aanderse

@aanderse
Copy link
Member

Haven't tested, but it builds so that seems like a good indicator. Thanks @etu!

@aanderse aanderse merged commit 2891726 into NixOS:master Dec 11, 2019
@etu etu deleted the php74-zip branch December 12, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 7.4 zip extension missing
2 participants
@etu @aanderse