Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-vm-tools: 10.3.10 -> 11.0.1 #75523

Merged
merged 1 commit into from Jan 11, 2020
Merged

open-vm-tools: 10.3.10 -> 11.0.1 #75523

merged 1 commit into from Jan 11, 2020

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented Dec 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @joamaki

@CheariX CheariX changed the title Open vm tools 11.0.1 open-vm-tools 10.3.10 -> 11.0.1 Dec 11, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build open-vm-tools

@aanderse
Copy link
Member

Didn't someone from the NixOS community try to upstream changes like this at one point? @peterhoeg do you have any recollection on that?

@worldofpeace
Copy link
Contributor

Oh, it's has been a while and I forgot to merge this patch.

@worldofpeace
Copy link
Contributor

Didn't someone from the NixOS community try to upstream changes like this at one point?

I also see no reason why such a patch ever could be rejected, if it was.
If I were the maintainer I'd merge it with swiftness 😄

@CheariX @worldofpeace
open-vm-tools: 10.3.10 -> 11.0.1
316c401 
Also update our downstream patch.
@worldofpeace worldofpeace changed the title open-vm-tools 10.3.10 -> 11.0.1 open-vm-tools: 10.3.10 -> 11.0.1 Jan 11, 2020
worldofpeace
worldofpeace approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've taken the liberty to rewrite your commit messages to match our guidelines.
Just waiting on eval now (just cuz).

@worldofpeace worldofpeace merged commit 3d67d02 into NixOS:master Jan 11, 2020
@peterhoeg
Copy link
Member

We cannot claim /etc/os-release ref vmware/open-vm-tools#35 (comment) for NixOS (well, we can if we do the patching on our side but it will not be accepted by upstream).

Upstream is terribly non-responsive as a proper fix was discussed in 2015 by @wmertens which to this date hasn't been even been acknowledged.

@CheariX CheariX deleted the open-vm-tools-11.0.1 branch January 15, 2020 13:43
@aanderse
Copy link
Member

Thanks @peterhoeg! Thanks @CheariX!

@CheariX CheariX mentioned this pull request Nov 24, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CheariX @worldofpeace @aanderse @peterhoeg @Janik-Haag