Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argo: 2.4.1 -> 2.4.3 #75475

Merged
merged 1 commit into from Dec 12, 2019
Merged

argo: 2.4.1 -> 2.4.3 #75475

merged 1 commit into from Dec 12, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Dec 11, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @groodt

@ofborg ofborg bot requested a review from ehmry December 11, 2019 03:27
@groodt
Copy link
Contributor Author

groodt commented Dec 11, 2019

Thanks for the review @ehmry

@ehmry ehmry merged commit b242eb0 into NixOS:master Dec 12, 2019
@ehmry
Copy link
Contributor

ehmry commented Dec 12, 2019

Sorry, I missed that you were cc'ing yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@groodt @ehmry