nixos/gdm: do not force the session #75489
Conversation
|
This isn't so simple. I need to do a little rewrite because it sets the session for all users. |
|
We agreed on this on irc https://logs.nix.samueldr.com/nixos-dev/2019-12-11#2873682; @hedning Could you just comment it for now? When the display-manager module is changed to actually make sense I'll switch this around a bit. |
|
Ah, didn't think of the multi user use-case.
Comment out the whole script to avoid the current problems you mean? |
|
I think I want to add the script to lightdm too 😈, the problem does not exist in #53843 any more. |
autoLogin works reliably there though, so it would only work for the https://gitlab.gnome.org/GNOME/gdm/issues/542 case. It should verifiable work in any dm with accountsservice support. |
While the problem doesn't exist because defaultSession is |
Having a default session resulted in GDM not remembering the last used session. So do not force the session until setSessionScript is made aware of the last session used.
hedning
force-pushed
the
gdm-only-default-with-auto
branch
from
9cc9635
to
d04157f
Compare
|
Lol, I bet in <2 days this todo will be gone. |
worldofpeace
changed the title
|
Unfortunately, this means we will have to rebase the other PR, otherwise
ofborg will not build it due to a conflict.
…On Wed, 11 Dec 2019, 14:41 worldofpeace, ***@***.***> wrote:
Merged #75489 <#75489> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#75489?email_source=notifications&email_token=AAFMEY5OLWI5RMB3X67EAITQYDUZZA5CNFSM4JZM3NSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVNJJXCY#event-2874317707>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMEYZ3PI364ZU3ULQB6CLQYDUZZANCNFSM4JZM3NSA>
.
|
Motivation for this change
Having a default session resulted in GDM not remembering the last used
session. Ideally the session script should only set the session if it
wasn't set before, but this is a quick fix which hopefully covers the
most common scenario.
Specifically I was logged into the xterm session and had to set the default desktopmanager to
noneto restore the previous behavior.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @