Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php build configuration #75451

Merged
merged 6 commits into from Feb 25, 2020
Merged

Update php build configuration #75451

merged 6 commits into from Feb 25, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 10, 2019

Motivation for this change

Changes in this PR:

  • Drop support build php wint maraidb connector-c. Php not support version 3.1.
  • Remove unused configure flags. The configureFlags+ option is not applied during build.
  • Add option config.php.pear
  • Add option config.php.ipv6
  • Build PHP with an external GD library
  • Update preConfigure phase. Needed for a correct build from git-source.

cc @etu @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

@Izorkin sorry for delay.
@etu I haven't had a chance to look at this yet. Do you have any capacity over the next couple weeks to review this?

@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 22, 2020

Updated and rebased.
cc @etu @aanderse @Mic92

Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks mostly fine to me. Have not tested yet.

@Mic92 Mic92 merged commit 21baef3 into NixOS:master Feb 25, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 25, 2020

Thanks!

@Izorkin Izorkin deleted the php-build branch February 25, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants