libhybris: 2018-06-18 -> 2019-12-02 #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two big things
The main issue with adbd (better described in commit messages and the patch) is that new versions of libhybris highly assume that you will be using libhybris with vendor libraries available.
This is not true here, and especially not with adbd in stage-1.
The adb daemon was running quite fine with the few bits of libhybris it was using, before they changed the behaviour. The added patch reverts the new behaviour to the older behaviour, which makes libhybris not load any libraries for adbd.
In the future, it might be ideal to extract the minimum libhybris required to run adbd, and rely on that instead.
This does mean that #30 will conflict, I'll rebase it on top of this PR.