Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 61cc9f34d208
Choose a base ref
...
head repository: NixOS/nix
compare: 98ef11677c43
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 10, 2019

  1. EvalState::callFunction(): Make FunctionCallTrace use less stack space 

    The FunctionCallTrace object consumes a few hundred bytes of stack
space, even when tracing is disabled. This was causing stack overflows:

  $ nix-instantiate '<nixpkgs> -A texlive.combined.scheme-full --dry-run
  error: stack overflow (possible infinite recursion)

This is with the default stack size of 8 MiB.

Putting the object on the heap reduces stack usage to < 5 MiB.
    @edolstra
    edolstra committed Dec 10, 2019
    Copy the full SHA
    98ef116 View commit details
    Browse the repository at this point in the history