New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teams: init at 1.2.00.32451 #75505
teams: init at 1.2.00.32451 #75505
Conversation
When trying to execute this package, It crashes with the following stacktrace :
The slack derivation seems to address this issue at line 50. I will try to do it locally when I get back from work. |
They're largely similar, but https://github.com/NixOS/nixpkgs/pull/75525/files uses autoPatchelfHook and wrapGAppsHook which i would've suggested here as well. Though the other is a draft. |
Changed to use |
Great ! It works perfectly for me with this update (no more |
pkgs/applications/networking/instant-messengers/teams/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/teams/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/teams/default.nix
Outdated
Show resolved
Hide resolved
This expression looks pretty ready @liff 👍 |
Since #75525 was closed, should I add @jonringer as a maintainer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will defer to people who actually use the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR and the software works as expected. Thank you very much @liff 🎉
@jonringer I'll leave it to you to convince whomever you need to convince that we need a linux port of outlook next 😉 😆
not sure why, but i was having problems on my workstation, home computer it works fine though |
I just did a call using this, the audio is very poor, not entire sure why. maybe using libpulseaudio will help remedy that |
also, it was eating my close application, :( |
@jonringer did not use for phone call but used during the day for regular stuff and so far no issues... What is close application? |
If I try to click the X in the upper right-hand corner |
Oh sorry I understand... I was able to click and then I received notification that Maybe I'll try to install on another device 🤔 |
The other thing is that, I'm only using lightdm+i3, and no desktop environment. Probably the cause of the wonky issues. |
Yeah definitely might be. I'm on I'll test voice call tomorrow. |
Motivation for this change
A Linux version of Microsoft Teams was released.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notes
It’s somewhat similar to Slack so I was using the slack derivation as a reference.