New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maestral: 0.4.2 -> 0.6.1 #75417
Merged
Merged
maestral: 0.4.2 -> 0.6.1 #75417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Dec 10, 2019
sdnotify systemd | ||
] ++ lib.optional withGui pyqt5); | ||
sdnotify | ||
systemd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if propagating theses is the right thing to do, personally I would wrap them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
peterhoeg
force-pushed
the
u/maestral_0_4_4
branch
from
December 18, 2019 10:57
e8dc592
to
0eacff7
Compare
peterhoeg
force-pushed
the
u/maestral_0_4_4
branch
from
January 13, 2020 13:45
0eacff7
to
b30f896
Compare
peterhoeg
force-pushed
the
u/maestral_0_4_4
branch
from
January 13, 2020 13:45
b30f896
to
cf27667
Compare
Thanks for your review @jonringer |
peterhoeg
force-pushed
the
u/maestral_0_4_4
branch
2 times, most recently
from
March 4, 2020 12:24
edb9b70
to
b298688
Compare
peterhoeg
force-pushed
the
u/maestral_0_4_4
branch
from
March 4, 2020 12:31
b298688
to
75f3ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream is rapidly improving.
Daily driver.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @