Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestral: 0.4.2 -> 0.6.1 #75417

Merged
merged 3 commits into from Mar 10, 2020
Merged

maestral: 0.4.2 -> 0.6.1 #75417

merged 3 commits into from Mar 10, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upstream is rapidly improving.

Daily driver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/maestral/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
sdnotify systemd
] ++ lib.optional withGui pyqt5);
sdnotify
systemd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if propagating theses is the right thing to do, personally I would wrap them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@peterhoeg peterhoeg changed the title maestral: 0.4.2 -> 0.4.4 maestral: 0.4.2 -> 0.5.0 Jan 13, 2020
@peterhoeg
Copy link
Member Author

Thanks for your review @jonringer

@peterhoeg peterhoeg force-pushed the u/maestral_0_4_4 branch 2 times, most recently from edb9b70 to b298688 Compare March 4, 2020 12:24
@peterhoeg peterhoeg changed the title maestral: 0.4.2 -> 0.5.0 maestral: 0.4.2 -> 0.6.1 Mar 4, 2020
@peterhoeg peterhoeg merged commit 228ef07 into NixOS:master Mar 10, 2020
@peterhoeg peterhoeg deleted the u/maestral_0_4_4 branch March 10, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants