hopper: fix libxml2 dynamic linking issue #75522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* port to qt5.callPackage / mkDerivation * format derivation
jtojnar
reviewed
Dec 11, 2019
FRidh
requested changes
Dec 11, 2019
* use wrapQtAppsHook in favour for the custom qt builder * use autoPatchelfHook * cleanup build dependencies * add maintainer Enteee
Enteee
force-pushed
the
bugfix/hopper
branch
from
db0b403
to
2f7f00b
Compare
jtojnar
requested changes
Dec 11, 2019
| maintainers = [ stdenv.lib.maintainers.luis ]; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| license = licenses.unfree; | ||
| maintainers = [ |
There was a problem hiding this comment.
Why not use with maintainers
| python27, | ||
| gmpxx, | ||
| }: | ||
| let |
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| mkdir -p $out/lib | ||
| mkdir -p $out/share | ||
|
|
||
| cp $sourceRoot/opt/hopper-${rev}/bin/Hopper $out/bin/hopper | ||
| cp -r $sourceRoot/opt/hopper-${rev}/lib $out | ||
| cp -r $sourceRoot/usr/share $out/share |
There was a problem hiding this comment.
This is installing files into $out/share/share
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| mkdir -p $out/lib | ||
| mkdir -p $out/share | ||
|
|
||
| cp $sourceRoot/opt/hopper-${rev}/bin/Hopper $out/bin/hopper | ||
| cp -r $sourceRoot/opt/hopper-${rev}/lib $out |
There was a problem hiding this comment.
I do not like all these libraries being vendored, could you perhaps only copy those that are not available in nixpkgs and add the rest to buildInputs?
── lib
│ ├── libBlocksRuntime.so.0
│ ├── libdispatch.so -> libdispatch.so.1
│ ├── libdispatch.so.0.1.3.1
│ ├── libdispatch.so.1 -> libdispatch.so.0.1.3.1
│ ├── libform.so.5
│ ├── libgnustep-base.so -> libgnustep-base.so.1.24
│ ├── libgnustep-base.so.1.24 -> libgnustep-base.so.1.24.9
│ ├── libgnustep-base.so.1.24.9
│ ├── libHopperCore.so
│ ├── libkqueue.so.0
│ ├── libncurses.so.5
│ ├── libobjc.so -> libobjc.so.4.6
│ ├── libobjc.so.4.6
│ ├── libobjcxx.so -> libobjcxx.so.4.6
│ ├── libobjcxx.so.4.6
│ ├── libpthread_workqueue.so.0
│ └── libtinfo.so.5
There was a problem hiding this comment.
libpthread_workqueue.so.0 might come from https://github.com/mheily/libpwq
There was a problem hiding this comment.
- libBlocksRuntime.so.0
- copy
- libdispatch.so.0.1.3.1
- copy
- libform.so.5
- copy
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libgnustep-base.so.1.24.9
- copy
- libHopperCore.so
- copy
- libkqueue.so.0
- copy
- libncurses.so.5
- copy
- scilab-bin.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libobjc.so.4.6
- copy
- gnustep.libobjc.out
- libobjcxx.so.4.6
- copy
- libpthread_workqueue.so.0
- copy
- libtinfo.so.5
- copy
- tlf.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- jetbrains.clion.out
- arduino-core.out
- arduino.out
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
generated with:
for l in *; do [ -L "${l}" ] && continue; echo "* ${l}"; echo " - [ ] copy"; nix-locate -1 -w "${l}" | sed -e 's/^/ - [ ] /' ; done | xclip
* add dependency to ncurses, gnustep * don't copy to share/share * run pre/post Install hooks * fix desktop icon * with maintainers
Enteee
force-pushed
the
bugfix/hopper
branch
from
fb8e87e
to
bb51742
Compare
jtojnar
reviewed
Dec 15, 2019
|
@jtojnar all review comments were implemented, please merge. |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 19, 2020
hopper: fix libxml2 dynamic linking issue (cherry picked from commit 2d87562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On channel:
nixpkgs-20.03pre202154.58fb23f72adhopper currently fails to start:Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @luis-hebendanz (Maintainer)
@ttuegel (Contributor)