Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oil: 0.7.pre6 -> 0.7.pre9 #75455

Merged
merged 1 commit into from Dec 11, 2019
Merged

oil: 0.7.pre6 -> 0.7.pre9 #75455

merged 1 commit into from Dec 11, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Dec 10, 2019 •
edited

Motivation for this change

http://www.oilshell.org/blog/2019/12/09.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann

@ofborg ofborg bot requested a review from lheckemann December 10, 2019 20:21
jonringer
jonringer approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75455
1 package were built:
oil

@jonringer jonringer merged commit 8a5cfec into NixOS:master Dec 11, 2019
@dywedir dywedir deleted the oil branch December 11, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @jonringer