Add GNU threading and Fortran libraries to MKL package #75526
Conversation
There was a problem hiding this comment.
The mkl package is getting quite big at this point. It might make sense to consider making a split-output derivation with a dev package that has the static libs, headers, and pcfiles, but it looks like your PR only takes it from 1.4G to 1.6G, so I could see that being done in a follow-up.
We install all the libraries on Darwin, so doing so on Linux as well seems like a good change to me.
CC @markuskowa if you have any opinions.
|
If you have an example on how to make a split-output derivation that I can
follow, I'd be happy to try, even in this PR.
…On Thu, Dec 12, 2019, 05:28 Benjamin Hipple ***@***.***> wrote:
***@***.**** approved this pull request.
The mkl package is getting quite big at this point. It might make sense
to consider making a split-output derivation with a dev package that has
the static libs, headers, and pcfiles, but it looks like your PR only takes
it from 1.4G to 1.6G, so I could see that being done in a follow-up.
We install all the libraries on Darwin, so doing so on Linux as well seems
like a good change to me.
CC @markuskowa <https://github.com/markuskowa> if you have any opinions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#75526?email_source=notifications&email_token=AA4JOEKGRBIDLBDHTJEHNATQYG4WJA5CNFSM4JZUJCCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCO5HSRA#pullrequestreview-330987844>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4JOEOLRHTDOC47FWJL2QTQYG4WJANCNFSM4JZUJCCA>
.
|
robertodr
changed the title
|
@c0bw3b I have amended the commit message. |
|
I would not package the static libraries by default. Could we make them optional (e.g. enableStatic)? @bhipple It would make sense at some point in the future to split the components MKL into separate derivations (for example mkl-base, mkl-scalapack, mkl-fftw, etc.) to make it smaller. One rarely needs all of the components at once. |
See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md |
And that would need to be disabled by default and enabled in an override in the |
|
The comments should have now been addressed. |
Signed-off-by: Roberto Di Remigio <roberto.diremigio@gmail.com>
|
@bhipple comment addressed. |
Motivation for this change
I have added the libraries needed to link using the GNU Fortran compiler and GNU threading libraries. These are the ones suggested by the MKL link line advisor.
Moreover, I also unpack the static version of all the libraries included.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bhipple