dotnet-sdk: add darwin support, set myself as maintainer #68709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
Signed-off-by: Jamie Winsor <jamie@onemoregame.com>
LnL7
reviewed
Sep 20, 2019
There was a problem hiding this comment.
This new expression has a lot of duplication with the default variant, conditionalizing the sources and patchelf calls would be better.
eg.
buildPhase = ''
runHook preBuild
${stdenv.lib.optionalString stdenv.isLinux ''
patchelf --set-interpreter "${stdenv.cc.bintools.dynamicLinker}" ./dotnet
patchelf --set-rpath "${rpath}" ./dotnet
find -type f -name "*.so" -exec patchelf --set-rpath '$ORIGIN:${rpath}' {} \;
''}
echo -n "dotnet-sdk version: "
./dotnet --version
runHook postBuild
'';| -change /System/Library/Frameworks/Security.framework/Versions/A/Security \ | ||
| ${Security}/Library/Frameworks/Security.framework/Security \ | ||
| -change /System/Library/Frameworks/GSS.framework/Versions/A/GSS \ | ||
| ${GSS}/Library/Frameworks/GSS.framework/GSS {} \; |
There was a problem hiding this comment.
Frameworks and things like libc are impure on darwin so rewriting references doesn't really do anything. It's fine to keep the system references since this is a precompiled binary anyway.
There was a problem hiding this comment.
Ah, thank you so much for the heads up there. It wasn't clear to me that the Darwin implementation wasn't impure. ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the dotnet core dotnet-sdk to the Darwin platform. This is my first commit to the nixpkgs repository so it also includes a modification to the maintainers list to include an entry for myself.
Apologies if I've gotten any of the contributing guidelines wrong, I did read them, I promise!
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)