Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux: 3.0 -> 3.0a #75518

Merged
merged 1 commit into from Dec 11, 2019
Merged

tmux: 3.0 -> 3.0a #75518

merged 1 commit into from Dec 11, 2019

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Dec 11, 2019 •
edited

Motivation for this change

Tmux 3.0 has some bugs, causing in particular tmux-resurrect to fail restoring sessions in certain cases.
Tmux 3.0a includes a couple of fixes: https://raw.githubusercontent.com/tmux/tmux/3.0a/CHANGES .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tobias-hammerschmidt @fpletz

@ofborg ofborg bot requested a review from fpletz December 11, 2019 16:54
lsix
lsix approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested.

@lsix lsix merged commit 8af0718 into NixOS:master Dec 11, 2019
@Pamplemousse Pamplemousse deleted the update_tmux branch December 13, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @lsix