Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The ispc test suite is brittle because it compares results to results computed with C. This is sensitive to things like non-associative floating point summation, using the x87 FPU, and vagaries of the system math library (functions like
sqrt()
are apparently not guaranteed by IEEE to be bit-exact).The test suite has caused problems before (#70260) and is causing problems again (#70846).
It makes little sense to refuse to install a compiler because a single test in its test suite fails. Besides, running the test suite also takes a relatively long time, and there is no guarantee it won't take even longer in the future.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @aristidb