ispc: set doCheck to false. #71134
Closed
ispc: set doCheck to false. #71134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Is there a way to filter the flakey tests? I would rather not discard tests which help in an automated fashion that something is broken. |
|
Possibly by hacking the test runner script, but it'd have to be done differently for different platforms (the SSE4 failures I fixed in #70260 are not the same as the failures in #70846). I think it is the wrong approach, and will just result in more maintenance in the future, so someone else would have to do it. Considering that ispc is an obscure package and essentially unmaintained in nixpkgs, I recommend slimming it down and maximising the likelihood that it will merely continue building. |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 4, 2019
ispc: add x86_64-darwin to platforms. Closes NixOS#71134 (cherry picked from commit 22378e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The ispc test suite is brittle because it compares results to results computed with C. This is sensitive to things like non-associative floating point summation, using the x87 FPU, and vagaries of the system math library (functions like
sqrt()are apparently not guaranteed by IEEE to be bit-exact).The test suite has caused problems before (#70260) and is causing problems again (#70846).
It makes little sense to refuse to install a compiler because a single test in its test suite fails. Besides, running the test suite also takes a relatively long time, and there is no guarantee it won't take even longer in the future.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @aristidb