Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.23.0 -> 0.25.0 #71135

Merged
merged 2 commits into from Oct 15, 2019
Merged

starship: 0.23.0 -> 0.25.0 #71135

merged 2 commits into from Oct 15, 2019

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Oct 14, 2019 •
edited

Motivation for this change

v0.24.0 (and then v0.25.0) of Starship was released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bbigras and me!

@ofborg ofborg bot requested a review from bbigras October 14, 2019 19:25
bbigras
bbigras approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine. thanks! 👍

@davidtwco davidtwco changed the title starship: 0.23.0 -> 0.24.0 starship: 0.23.0 -> 0.25.0 Oct 15, 2019
@davidtwco
Copy link
Member Author

@bbigras I've updated this PR as v0.25.0 was released since I put this PR up.

@ofborg ofborg bot requested a review from bbigras October 15, 2019 16:33
bbigras
bbigras approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine 👍 thanks

@dywedir
Copy link
Member

dywedir commented Oct 15, 2019

@GrahamcOfBorg build starship

@dywedir dywedir merged commit a1d6921 into NixOS:master Oct 15, 2019
@davidtwco davidtwco deleted the starship-0.24.0 branch October 17, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidtwco @dywedir @bbigras