Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metamath: 0.172 -> 0.178 #71177

Merged
merged 1 commit into from
Oct 15, 2019
Merged

metamath: 0.172 -> 0.178 #71177

merged 1 commit into from
Oct 15, 2019
+11 −9

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Oct 15, 2019

This also moves away from my mirror of the distributiont one hosted by the metamath organization, which should generally be far more up-to-date. However, that doesn't include any data files, so we need to make sure we don't try to make those.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 15, 2019
gebner
gebner reviewed Oct 15, 2019
View reviewed changes
pkgs/development/interpreters/metamath/default.nix Outdated
@@ -11,12 +11,18 @@ stdenv.mkDerivation {
# no permanent link. See discussion at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be removed now, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the comment, thanks for spotting it.

metamath: 0.172 -> 0.178

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rycee Robert Helgesson
GPG key ID: 36BDAA14C2797E89
Expired
Verified
Learn about vigilant mode
fc0be2a 
This also moves away from my mirror of the distributiont one hosted by
the metamath organization, which should generally be far more
up-to-date. However, that doesn't include any data files, so we need to
make sure we don't try to make those.
@gebner gebner merged commit f3ecf7d into NixOS:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Taneb @gebner