Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screenfetch: add to path pciutils #71205

Merged
merged 1 commit into from Oct 19, 2019
Merged

screenfetch: add to path pciutils #71205

merged 1 commit into from Oct 19, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 15, 2019 •
edited

Motivation for this change

Fix this error
/nix/store/kgx9r4wd1r8bv93s204yw4y2n85qnm8j-screenFetch-3.9.0/bin/.screenfetch-wrapped: line 1653: lspci: command not found

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code is here
https://github.com/KittyKatt/screenFetch/blob/a7d06fe526fac903174c5b0832b16b6efec45996/screenfetch-dev#L1653

@worldofpeace
Copy link
Contributor

Checked that the darwin failure is not new.

@worldofpeace worldofpeace merged commit 66239bc into NixOS:master Oct 19, 2019
@worldofpeace
Copy link
Contributor

backported in 372dd72

@Izorkin Izorkin deleted the fix-screenfetch branch October 19, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @worldofpeace