Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arion-compose: Enable without tests #71132

Closed
wants to merge 1 commit into from
Closed

arion-compose: Enable without tests #71132

wants to merge 1 commit into from
+7 −1

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 14, 2019

Motivation for this change

This packages a component of the arion tool for docker deployments with Nix.
It is a prerequisite to #71092

Note that it has a different name "arion-compose" because "arion" was already taken on
Hackage before arion switched to Haskell.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@roberth
arion-compose: Enable without tests
755ac13 
This adds me as a maintainer of arion-compose, which provides the
executable for the arion package (NixOS#71092).

Note that it has a different name because it was already taken on
Hackage before arion switched to Haskell.
@roberth roberth requested a review from cdepillabout October 14, 2019 17:36
@roberth roberth requested a review from basvandijk as a code owner October 14, 2019 17:36
@roberth
Copy link
Member Author

roberth commented Oct 14, 2019

Wrong target branch. Should have been haskell-updates.

@roberth roberth closed this Oct 14, 2019
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

@basvandijk basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@roberth