Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "libbsd: 0.9.1 -> 0.10.0 (#66948)"" #71087

Merged
merged 2 commits into from Oct 14, 2019
Merged

Revert "Revert "libbsd: 0.9.1 -> 0.10.0 (#66948)"" #71087

merged 2 commits into from Oct 14, 2019

Conversation

matthewbauer
Copy link
Member

This reverts commit 9e7582c.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
Revert "Revert "libbsd: 0.9.1 -> 0.10.0 (NixOS#66948)""
7d364b9 
This reverts commit 9e7582c.

* Updates libbsd along with the darwin.patch.
* Upstream PR for darwin.patch can be found at
https://gitlab.freedesktop.org/libbsd/libbsd/merge_requests/3.
* musl.patch is removed.
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 13, 2019

@GrahamcOfBorg build libbsd opendkim acme-client

@c0bw3b c0bw3b mentioned this pull request Oct 14, 2019
Closed
@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

This now fails to build on linux.

@matthewbauer
libbsd: update darwin.patch
0a13901 
fix multiple version map flags
@matthewbauer matthewbauer merged commit 1016bfc into NixOS:master Oct 14, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

Thanks @matthewbauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b Awaiting requested review from c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @c0bw3b @flokli