Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackage.RPCEPCService: Init at 0.0.11 #71153

Merged
merged 1 commit into from Oct 19, 2019
Merged

perlPackage.RPCEPCService: Init at 0.0.11 #71153

merged 1 commit into from Oct 19, 2019

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 15, 2019 •
edited by c0bw3b

Add the RPCEPCService perl package, and its dependency DataSExpression.

Motivation for this change

RPC::EPC::Service is a required dependency of the edbi Emacs package.

Things done

These were autogenerated with nix-generate-from-cpan.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthuszagh
perlPackage.RPCEPCService: Init at 0.0.11
b740642 
Add the RPCEPCService perl package, and its
dependency DataSExpression.
matthuszagh added a commit to matthuszagh/nixpkgs that referenced this pull request Oct 17, 2019
@matthuszagh
perlPackage.RPCEPCService: Init at 0.0.11 NixOS#71153
0d4fa82
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 17, 2019 •
edited

Have you been able to test these locally?
(see the checkboxes of the PR template)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 17, 2019

@GrahamcOfBorg build perl528Packages.RPCEPCService perl530Packages.RPCEPCService perl528Packages.DataSExpression perl530Packages.DataSExpression

@matthuszagh
Copy link
Contributor Author

I've tested this in a sandboxed environment on NixOS. Checkboxes updated to reflect that.

c0bw3b
c0bw3b approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71153 1

4 package were build:
  • perl528Packages.DataSExpression
  • perl528Packages.RPCEPCService
  • perl530Packages.DataSExpression
  • perl530Packages.RPCEPCService

@c0bw3b c0bw3b merged commit af5ddcd into NixOS:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @c0bw3b