Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: 6.9.9-34 -> 6.9.10-68, fixing numerous CVEs #71099

Merged
merged 1 commit into from Oct 14, 2019
Merged

imagemagick: 6.9.9-34 -> 6.9.10-68, fixing numerous CVEs #71099

merged 1 commit into from Oct 14, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 13, 2019

Motivation for this change

To get an idea of how numerous see #70099

I haven't done a full nix-review yet as I don't have the resources, but everything I've rebuilt so far has been ok...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from the-kenny October 13, 2019 23:59
@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

@risicle Thanks for the PR! Bumping from 6.9.9 to 6.9.10 shouldn't be a problem, also when backporting to 19.09.

Did you check how hard it'll be to upgrade nixpkgs master to imagemagick 7.x (in a followup PR)?

@flokli flokli merged commit 2a25463 into NixOS:master Oct 14, 2019
@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

backported to 19.09 in 29d40ef.

@risicle
Copy link
Contributor Author

risicle commented Oct 14, 2019

Did you check how hard it'll be to upgrade nixpkgs master to imagemagick 7.x (in a followup PR)?

I didn't get on to that - my machine spent most of Sunday building less than a quarter of the 6.x reverse deps.

@flokli
Copy link
Contributor

flokli commented Oct 14, 2019 via email

@risicle
Copy link
Contributor Author

risicle commented Oct 14, 2019

I mean I didn't even look at 7.x, I'm already spinning ~6 open CVE PRs as it is.

@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

All good :-) Thanks a lot 👍

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 15, 2019
@flokli @dtzWill
imagemagick: 6.9.9-34 -> 6.9.10-68, fixing numerous CVEs (NixOS#71099)
eea6fe7 
imagemagick: 6.9.9-34 -> 6.9.10-68, fixing numerous CVEs
(cherry picked from commit 2a25463)
@flokli flokli mentioned this pull request Oct 21, 2019
Closed
19 tasks
@pacien
Copy link
Contributor

pacien commented Oct 27, 2019

This update broke the tests of the gscan2pdf package because of ImageMagick/ImageMagick#1632 and ImageMagick/ImageMagick#1636. The issue seems to be fixed in 6.9.10-69 and 7.0.9-0.

Would it be possible to have a new update and a backport for 19.09?

@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

Submit the PR :)

@risicle risicle mentioned this pull request Oct 27, 2019
Merged
10 tasks
@flokli flokli mentioned this pull request Nov 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @flokli @pacien @veprbl