Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] Reliable epson #71098

Merged
merged 2 commits into from
Oct 15, 2019
Merged

[19.09] Reliable epson #71098

merged 2 commits into from
Oct 15, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Oct 13, 2019

Motivation for this change

Backport of #70491.
Basically a fix for all the proprietary epson drivers with issues on removed src files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

+ added webarchive source for reliable builds in the future

(cherry picked from commit bbb71bf)
+ added webarchive source for reliable builds in the future
+ removed `${version}` from url, as it actually adds more hassle to
  have it in there and no benefits whatsoever, since the url keeps
  changing other parts too

(cherry picked from commit 4db7494)
@Lassulus
Copy link
Member

you can add [19.09] to the title, so people can easily spot the backport

@wucke13 wucke13 changed the title Reliable epson [19.09] Reliable epson Oct 13, 2019
@Lassulus Lassulus merged commit 436cf05 into NixOS:release-19.09 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants