Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: fix gnome-flashback #71210

Merged
merged 2 commits into from Oct 18, 2019
Merged

nixos/gnome3: fix gnome-flashback #71210

merged 2 commits into from Oct 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This session would fail to start because we didn't have it in systemd.packages
(as we've switched to systemd gnome-session).

Haven't tested custom sessions.

Also investigating a gnome-flashback test as a part of gnome3-xorg test and gnome-classic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace changed the title nixos/gnome3: fix gnome-flashaback nixos/gnome3: fix gnome-flashback Oct 16, 2019
@worldofpeace
nixos/gnome3: fix gnome-flashback
60aedad 
This session would fail to start because we didn't have it in systemd.packages
(as we've switched to systemd gnome-session).

Haven't tested custom sessions.
@worldofpeace worldofpeace mentioned this pull request Oct 16, 2019
Closed
10 tasks
@worldofpeace
Copy link
Contributor Author

Noticed there was a gschema override we needed to accommodate 0dbbeab.

@worldofpeace worldofpeace merged commit cf05f70 into NixOS:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace