Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Python: use NIX_PYTHONPATH everywhere instead of PYTHONPATH #71118

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

I know that having to rely on PYTHONPATH has been a constant source of pain, but what problems does this solve? (I honestly don't know :))

@FRidh
Copy link
Member Author

FRidh commented Oct 14, 2019

We can export NIX_PYTHONPATH without breaking support for PYTHONPATH.

@jonringer
Copy link
Contributor

this seems to cause the package to appear twice during the pythonCatchConflictsPhase

checking for references to /build/ in /nix/store/1ysh1pxvgh71zkzsbglbwcrvamnw88n0-python3.7-atomicwrites-1.3.0...
pythonCatchConflictsPhase
Found duplicated packages in closure for dependency 'atomicwrites':
  atomicwrites 1.3.0 (/nix/store/1ysh1pxvgh71zkzsbglbwcrvamnw88n0-python3.7-atomicwrites-1.3.0/lib/python3.7/site-packages)
  atomicwrites 1.3.0 (/build/atomicwrites-1.3.0)

Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.
builder for '/nix/store/761cgkm5nn73rs6vbw4n2ljh1nmbdi6l-python3.7-atomicwrites-1.3.0.drv' failed with exit code 1
cannot build derivation '/nix/store/5x18wwnk4dnxx3wxw00jmzhr6lhrn1an-python3.7-pytest-5.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5x18wwnk4dnxx3wxw00jmzhr6lhrn1an-python3.7-pytest-5.1.0.drv' failed

@FRidh
Copy link
Member Author

FRidh commented Oct 15, 2019

Also, NIX_PYTHONPATH gets unset immediately, so it would not break #71110.

@FRidh FRidh added this to WIP in Staging Nov 2, 2019
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:04
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 23, 2020
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
WIP
Development

Successfully merging this pull request may close these issues.

None yet

2 participants