Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] ocrmypdf: 8.2.3 -> 9.0.3 #71149

Merged
merged 1 commit into from Oct 18, 2019
Merged

[19.09] ocrmypdf: 8.2.3 -> 9.0.3 #71149

merged 1 commit into from Oct 18, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 14, 2019

Motivation for this change

This fixes ocrmypdf in nixpkgs 19.09, which currently shows:

# ocrmypdf --help
Traceback (most recent call last):
  File "/nix/store/b0lv6kp74xs12bh05jprlw6q4p37hsg7-ocrmypdf-8.2.3/bin/.ocrmypdf-wrapped", line 7, in <module>
    from ocrmypdf.__main__ import run_pipeline
  File "/nix/store/b0lv6kp74xs12bh05jprlw6q4p37hsg7-ocrmypdf-8.2.3/lib/python3.7/site-packages/ocrmypdf/__init__.py", line 18, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Kiwi

@Kiwi @ivan
ocrmypdf: 8.2.3 -> 9.0.3
57a1576 
Version bump and bug fix
Fixes runtime dependencies ( NixOS#67497 ) and the version bump fixed other issues

(cherry picked from commit 82c4218)
@ofborg ofborg bot requested a review from Kiwi October 14, 2019 22:12
worldofpeace
worldofpeace suggested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bumps in backports aren't really desirable. It'll for sure not include just bug fixes and security updates. I'm not sure how @Kiwi would think about not doing the update, but keeping the rest of the diff.

@Kiwi
Copy link
Member

Kiwi commented Oct 18, 2019

I am currently on 19.09 and ran this with nix-review pr 71149 on several test inputs (as well as --help) successfully.

@worldofpeace worldofpeace merged commit c107ff9 into NixOS:release-19.09 Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@Kiwi Kiwi Kiwi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @Kiwi @worldofpeace