Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.27 -> 1.8.28 (CVE-2019-14287) [19.09] #71145

Merged
merged 1 commit into from Oct 14, 2019
Merged

sudo: 1.8.27 -> 1.8.28 (CVE-2019-14287) [19.09] #71145

merged 1 commit into from Oct 14, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 14, 2019

Motivation for this change

https://www.sudo.ws/alerts/minus_1_uid.html

Latest sudo CVE allows trivial local privilege escalation by restricted sudoers. Tested that the vulnerability does not work anymore, and through nixos/tests/sudo.nix.

Cherry-pick -x of #71144 to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@ofborg ofborg bot requested a review from edolstra October 14, 2019 21:43
@delroth
Copy link
Contributor Author

delroth commented Oct 14, 2019

@GrahamcOfBorg test sudo

@matthewbauer matthewbauer merged commit 90b13f6 into NixOS:release-19.09 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @matthewbauer @veprbl