Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Gnome 3.34.1 #71147

Merged
merged 15 commits into from Oct 16, 2019
Merged

More Gnome 3.34.1 #71147

merged 15 commits into from Oct 16, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 14, 2019
@ofborg ofborg bot requested a review from hedning October 15, 2019 20:53
hedning
hedning approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 1f470a5 into NixOS:master Oct 16, 2019
@worldofpeace worldofpeace deleted the gnome-3.34.1-more branch October 16, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@astsmtl astsmtl Awaiting requested review from astsmtl

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@Phreedom Phreedom Awaiting requested review from Phreedom

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @hedning