Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbtools: propagate setuptools #71180

Merged
merged 1 commit into from Nov 14, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

rbtools is broken because it is missing setuptools:

Traceback (most recent call last):
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/bin/.rbt-wrapped", line 7, in <module>
    from rbtools.commands.main import main
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/lib/python2.7/site-packages/rbtools/commands/__init__.py", line 16, in <module>
    from rbtools.api.client import RBClient
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/lib/python2.7/site-packages/rbtools/api/client.py", line 5, in <module>
    from rbtools.api.transport.sync import SyncTransport
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/lib/python2.7/site-packages/rbtools/api/transport/sync.py", line 4, in <module>
    from rbtools.api.factory import create_resource
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/lib/python2.7/site-packages/rbtools/api/factory.py", line 3, in <module>
    from rbtools.api.resource import (CountResource, ItemResource,
  File "/nix/store/h0w1wr06n5wyk7v978n8ysyajw2m55m9-python2.7-rbtools-0.7.2/lib/python2.7/site-packages/rbtools/api/resource.py", line 6, in <module>
    from pkg_resources import parse_version
ImportError: No module named pkg_resources
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants